Update io from v3.14.3 and fix by youknowone · Pull Request #7089 · RustPython/RustPython

youknowone · 2026-02-11T16:30:27Z

Summary by CodeRabbit

New Features
- Added resize() to PyByteArray.
- Added getbuffer() to BytesIO.
- BytesIO constructor now accepts an optional initial-bytes argument for direct buffer initialization.
Bug Fixes
- Prevent negative-relative seeks from moving before the buffer start.
- Close now prevents closing when exports exist and returns proper errors for closed IO.
Chores
- Marked io module dependency on _pyio.py and minor dependency/path updates.
- UnsupportedOperation now carries correct module metadata for introspection.

coderabbitai · 2026-02-11T16:30:41Z

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Adds PyByteArray::resize, refactors BytesIO initialization to use BytesIOArgs, tightens BytesIO seek/close/getbuffer semantics (including closed/export checks), sets UnsupportedOperation.module, and records _pyio.py as a hard dependency in update_lib tooling.

Changes

Cohort / File(s)	Summary
ByteArray `crates/vm/src/builtins/bytearray.rs`	Added `PyByteArray::resize(size: isize, vm: &VirtualMachine) -> PyResult<()>` — validates non-negative sizes, raises `ValueError` for negatives, resizes internal buffer and zero-fills new bytes.
BytesIO & IO types `crates/vm/src/stdlib/io.rs`	Introduced `BytesIOArgs` and changed `BytesIO::init` to accept it; adjusted seek to clamp negative relative seeks; changed `close(&self)` → `close(&self, vm: &VirtualMachine) -> PyResult<()>` with export-count guard; added `getbuffer()` returning `PyMemoryView` with closed-state check; set `UnsupportedOperation.__module__ = "io"`.
update_lib tooling `scripts/update_lib/cmd_quick.py`, `scripts/update_lib/deps.py`	Switched `dep_lib_path` construction to `pathlib.Path("Lib") / dep_name`; added `_pyio.py` as a hard dependency for the `io` module in dependency mappings.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

Upgrade test_io from 3.13.11 and fix more io tests #6565: Modifications to crates/vm/src/stdlib/io.rs affecting BytesIO initialization/close/getbuffer behavior.
Update io from v3.14.3 and fix #7089: Overlapping edits to BytesIO APIs and adds similar PyByteArray::resize and update_lib changes.

Poem

🐰 I nibble bytes and stretch each line,

Resize the heap with hops divine.
No seeking past the start, I say—
Close with care, keep exports at bay.
Memory views gleam in carrot-ray 🥕✨

🚥 Pre-merge checks | ✅ 2 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 58.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title is vague and incomplete, using generic phrasing 'and fix' without specifying what is being fixed or updated in the io module.	Revise the title to be more specific about the changes, such as 'Add resize method to PyByteArray and enhance BytesIO' or 'Update io module with PyByteArray resize and BytesIO improvements'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into `main`

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-02-11T16:30:57Z

Code has been automatically formatted

The code in this PR has been formatted using:

cargo fmt --all
Please pull the latest changes before pushing again:

git pull origin io

- Add bytearray.resize() method - BytesIO: support keyword arg for initial_bytes - BytesIO.seek: clamp negative positions to 0 - BytesIO.close: raise BufferError on active exports - BytesIO.getbuffer: check closed state - Set UnsupportedOperation.__module__ to "io"

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@scripts/update_lib/cmd_quick.py`:
- Around line 409-410: The code sets dep_lib_path =
pathlib.Path("crates/pylib/Lib") / dep_name which stages hard dependencies from
the generated location; change it to use the canonical Lib directory by setting
dep_lib_path = pathlib.Path("Lib") / dep_name (matching how lib_file_path is
derived) so hard deps are sourced from Lib/ rather than crates/pylib/Lib; update
any related references in the same block that rely on dep_lib_path to use the
new path variable.

scripts/update_lib/cmd_quick.py

github-actions · 2026-02-13T06:25:10Z

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] lib: cpython/Lib/io.py
[x] lib: cpython/Lib/_pyio.py
[ ] test: cpython/Lib/test/test_io.py (TODO: 25)
[x] test: cpython/Lib/test/test_bufio.py
[ ] test: cpython/Lib/test/test_fileio.py (TODO: 2)
[ ] test: cpython/Lib/test/test_memoryio.py (TODO: 29)

dependencies:

io

dependent tests: (87 tests)

io: test__colorize test_android test_argparse test_ast test_asyncio test_bufio test_builtin test_bz2 test_calendar test_cmd test_cmd_line_script test_codecs test_compileall test_compiler_assemble test_concurrent_futures test_configparser test_contextlib test_csv test_dbm_dumb test_dis test_email test_enum test_file test_fileinput test_fileio test_ftplib test_getpass test_gzip test_hashlib test_httplib test_httpservers test_importlib test_inspect test_io test_json test_largefile test_logging test_lzma test_mailbox test_marshal test_memoryio test_memoryview test_mimetypes test_optparse test_pathlib test_pickle test_pickletools test_plistlib test_pprint test_print test_pty test_pulldom test_pyexpat test_regrtest test_robotparser test_shlex test_shutil test_site test_smtplib test_socket test_socketserver test_subprocess test_support test_sys test_tarfile test_tempfile test_threadedtempfile test_timeit test_tokenize test_traceback test_typing test_unittest test_univnewlines test_urllib test_urllib2 test_uuid test_wave test_wsgiref test_xml_dom_xmlbuilder test_xml_etree test_xml_etree_c test_xmlrpc test_zipapp test_zipfile test_zipimport test_zoneinfo test_zstd

[x] lib: cpython/Lib/typing.py
[ ] test: cpython/Lib/test/test_typing.py (TODO: 5)
[x] test: cpython/Lib/test/test_type_aliases.py
[x] test: cpython/Lib/test/test_type_annotations.py (TODO: 1)
[x] test: cpython/Lib/test/test_type_params.py (TODO: 10)
[x] test: cpython/Lib/test/test_genericalias.py

dependencies:

typing

dependent tests: (13 tests)

typing: test_annotationlib test_builtin test_enum test_fractions test_funcattrs test_functools test_genericalias test_grammar test_isinstance test_type_aliases test_type_params test_types test_typing

Legend:

[+] path exists in CPython
[x] up-to-date, [ ] outdated

youknowone force-pushed the io branch 4 times, most recently from 1924eb7 to 0b79cf4 Compare February 12, 2026 09:29

[update_lib] _pyio deps

190cecd

youknowone force-pushed the io branch 2 times, most recently from 34fe444 to 0a3ac12 Compare February 13, 2026 05:10

CPython Developers and others added 3 commits February 13, 2026 14:13

Update io from v3.14.3

9924e29

mark typing

8f0c6e9

youknowone force-pushed the io branch from 0a3ac12 to 8f0c6e9 Compare February 13, 2026 05:13

youknowone marked this pull request as ready for review February 13, 2026 06:11

coderabbitai bot reviewed Feb 13, 2026

View reviewed changes

scripts/update_lib/cmd_quick.py Outdated Show resolved Hide resolved

youknowone commented Feb 13, 2026

View reviewed changes

scripts/update_lib/cmd_quick.py Outdated Show resolved Hide resolved

Update scripts/update_lib/cmd_quick.py

718e74d

youknowone merged commit 743780f into RustPython:main Feb 13, 2026
13 of 14 checks passed

youknowone deleted the io branch February 13, 2026 06:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update io from v3.14.3 and fix#7089

Update io from v3.14.3 and fix#7089
youknowone merged 5 commits intoRustPython:mainfrom
youknowone:io

youknowone commented Feb 11, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 11, 2026 •

edited

Loading

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

youknowone commented Feb 11, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 13, 2026

📦 Library Dependencies

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

youknowone commented Feb 11, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 11, 2026 •

edited

Loading