Add support for compiling against the sdk2013 branch#173
Add support for compiling against the sdk2013 branch#173Ayuto merged 9 commits intoSource-Python-Dev-Team:engine_sdk2013from TheCreeper:engine_sdk2013
Conversation
…urce.Python into engine_sdk2013
There are some things in KeyValues.cpp that are not supported in c++11
Ayuto
left a comment
Ayuto
left a comment
There was a problem hiding this comment.
Thanks for the PR! Please read my comments and make the appropriate changes. Once that is done, I will merge your PR. But before merging the whole branch, we will need to fix the compiling issue on Windows.
| Set(SOURCEPYTHON_KEYVALUES_MODULE_SOURCES | ||
| core/modules/keyvalues/keyvalues_wrap.cpp | ||
| ${SOURCESDK}/tier1/KeyValues.cpp | ||
| ${SOURCESDK}/public/tier1/KeyValues.h |
There was a problem hiding this comment.
That line could be removed completely as it gets included in shared.make.
|
|
||
| Set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} \ | ||
| -DINTERFACEVERSION_SERVERGAMEDLL=\"ServerGameDLL010\"") | ||
|
|
There was a problem hiding this comment.
We should add a note that these two lines should be removed once the SDK has been updated:
https://github.com/alliedmodders/hl2sdk/blob/3957adff10fe20d38a62fa8c018340bf2618742b/public/eiface.h#L459-L467
| # Others | ||
| Set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -mfpmath=sse -msse -m32 -fno-strict-aliasing") | ||
| Set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x -fno-threadsafe-statics -v -fvisibility=hidden") | ||
| Set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x -static-libgcc -static-libstdc++ -fno-threadsafe-statics -v -fvisibility=hidden") |
There was a problem hiding this comment.
static-libstdc++ doesn't compile well with CS:GO. Once you start the server SP will fail to load with undefined symbol: _zdlpv.
2 participants
This resolves the compiling issues and seems to work after testing, the data files for sdk2013 aren't included however.