Conversation
23doors
reviewed
Oct 3, 2016
Member
23doors
left a comment
23doors
left a comment
There was a problem hiding this comment.
looks good. just maybe that public ssh could be made a little more secure, just in case
Dockerfile
Outdated
| CMD "python" | ||
| RUN apt-get update && apt-get install -y openssh-server | ||
| RUN mkdir /var/run/sshd /root/.ssh | ||
| COPY python/files/id_rsa.pub /root/.ssh/authorized_keys |
Member
There was a problem hiding this comment.
it's just some random ssh key used for installation right? Maybe we should remove it and disable ssh after we're done. Seems like a potential security threat at some point
Contributor
Author
There was a problem hiding this comment.
we remove it during deploy - I'll leave it here for sake of simplicity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is nice