Skip to content

Add customization for the "Menu" label. #70818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dhananjaykuber wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Add customization for the "Menu" label. #70818

dhananjaykuber wants to merge 3 commits into from

Conversation

@dhananjaykuber
Copy link
Contributor

@dhananjaykuber dhananjaykuber commented Jul 21, 2025

Closes #56040

What?

Adds two new feature to the Navigation block for customizing menu label.

Why?

This PR improves accessibility and flexibility by allowing the open/close button labels to be customized instead of using hardcoded text

How?

  • Adds two new attributes to the Navigation block: menuOpenLabel and menuCloseLabel.
  • Update edit function and frontend rendering of menu label.

Testing Instructions

  • Insert or select the Navigation block.
  • In Inspector Controls head to Display and click on the Display icon button
  • Toggle off the Show icon button
  • Enter Menu open label and Menu close label value
  • See the changes in editor
  • Save the page/post and see changes on frontend

Screenshots or screencast

screen-capture.webm

@github-actions
Copy link

github-actions bot commented Jul 21, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @alaczek.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: alaczek.

Co-authored-by: dhananjaykuber <[email protected]>
Co-authored-by: seifeldinio <[email protected]>
Co-authored-by: scruffian <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. [Block] Navigation Affects the Navigation Block labels Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@ndiego ndiego Awaiting requested review from ndiego

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Navigation: Customize the "Menu" label.

2 participants

@dhananjaykuber @t-hamano