Skip to content

Add text indext control #70861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dhananjaykuber wants to merge 4 commits into from
Closed

Add text indext control #70861

dhananjaykuber wants to merge 4 commits into from

Conversation

@dhananjaykuber
Copy link
Contributor

@dhananjaykuber dhananjaykuber commented Jul 23, 2025 •
edited
Loading

Closes #55225

What?

This PR implements a new Text Indent control component and integrates it into the Paragraph block's typographic settings.

Why?

Lacked a direct way to control text indentation.

How?

A new control component has been developed to manage text indentation values.

Testing Instructions

  • Add a Paragraph Block and add text in that
  • In Typograph settings of block select Text Indent
  • Add Text Indent value
  • See the changes on editor
  • Save post and see changes on frontend

Screenshots or screencast

Screenshot 2025-07-23 at 1 53 52 PM Screenshot 2025-07-23 at 1 57 50 PM Screenshot 2025-07-23 at 1 58 04 PM

@github-actions
Copy link

github-actions bot commented Jul 23, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dhananjaykuber <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: simom <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

t-hamano
t-hamano reviewed Jul 23, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Ideally, we should discuss whether this style should be added as block support. An ad-hoc approach would make it harder to migrate to block support in the future. That is, it should work like this.

block.json:

{
	"apiVersion": 3,
	"name": "core/paragraph",
	"title": "Paragraph",
	"supports": {
		"typography": {
			"textIndent": true
		}
	}
}

Moreover, we should probably support this in the global styles as well, so in theme.json we'd have something like this:

{
	"$schema": "../../schemas/json/theme.json",
	"version": 3,
	"settings": {
		"blocks": {
			"core/paragraph": {
				"typography": {
					"textIndent": true
				}
			}
		}
	},
	"styles": {
		"blocks": {
			"core/paragraph": {
				"typography": {
					"textIndent": "20px"
				}
			}
		}
	}
}

@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. [Block] Paragraph Affects the Paragraph Block [Package] Block editor /packages/block-editor labels Jul 23, 2025
@t-hamano t-hamano mentioned this pull request Jul 23, 2025
Closed
@t-hamano
Copy link
Contributor

t-hamano commented Jul 23, 2025

See: #55225 (comment)

@t-hamano
Copy link
Contributor

t-hamano commented Jul 24, 2025

I think this feature would be best worked into the theme.json layer first, without exposing the UI. Let's close this PR in favor of #59496.

cc @MaggieCabrera

@t-hamano t-hamano closed this Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-hamano t-hamano t-hamano left review comments

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@ndiego ndiego Awaiting requested review from ndiego

Assignees

No one assigned

Labels

[Block] Paragraph Affects the Paragraph Block [Package] Block editor /packages/block-editor [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Text indent control for typographic elements

2 participants

@dhananjaykuber @t-hamano