Skip to content

fix: notes help text #72819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dhruvang21 wants to merge 2 commits into from
Closed

fix: notes help text #72819

dhruvang21 wants to merge 2 commits into from

Conversation

@dhruvang21
Copy link
Contributor

@dhruvang21 dhruvang21 commented Oct 30, 2025

What?

Closes #72771

Why?

This PR solves the confusion created by note help text.

Confusion :
The message made me think it was a bug, that the system thought I wasn't logged in. I thought I had to do something to enable notes.

How?

By adding the appropriate help message suggested by @dmsnell

Testing Instructions

  1. Open a post or page.
  2. Open notes.

Screenshots or screencast

Before After
Before: Notes sidebar message After: Improved Notes sidebar message

@github-actions
Copy link

github-actions bot commented Oct 30, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dhruvang21 <[email protected]>
Co-authored-by: jeffpaul <[email protected]>
Co-authored-by: hanneslsm <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: jeryj <[email protected]>
Co-authored-by: jasmussen <[email protected]>
Co-authored-by: desrosj <[email protected]>
Co-authored-by: dmsnell <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

jeffpaul
jeffpaul reviewed Oct 30, 2025
View reviewed changes
@t-hamano t-hamano added [Type] Copy Issues or PRs that need copy editing assistance [Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting labels Oct 31, 2025
@github-project-automation github-project-automation bot moved this to 🔎 Needs Review in WordPress 6.9 Editor Tasks Oct 31, 2025
@dhruvang21 dhruvang21 requested a review from jeffpaul November 3, 2025 13:21
@t-hamano t-hamano mentioned this pull request Nov 4, 2025
Closed
6 tasks
@t-hamano
Copy link
Contributor

t-hamano commented Nov 4, 2025

Hi @dhruvang21, we decided not to render the notes sidebar itself when there are no notes yet in that post. As a result, the help text is no longer displayed. See #72771 (comment) for more details.

Therefore, we will close this PR, but thank you for your efforts!

@t-hamano t-hamano closed this Nov 4, 2025
@github-project-automation github-project-automation bot moved this from 🔎 Needs Review to ✅ Done in WordPress 6.9 Editor Tasks Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffpaul jeffpaul Awaiting requested review from jeffpaul

Assignees

No one assigned

Labels

[Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting [Type] Copy Issues or PRs that need copy editing assistance

Projects

WordPress 6.9 Editor Tasks
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Notes: “Only logged in users can see Notes.” when logged in.

3 participants

@dhruvang21 @t-hamano @jeffpaul