Add EXIF metadata tests for Client Side Media #74909
Open
+330
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsilverstein
requested review from
ajitbohra,
ellatrix,
nerrad,
ntwb and
spacedmonkey
as code owners
github-actions
bot
added
[Package] Core data
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
adamsilverstein
changed the base branch from
trunk
to
feature/client-side-media-dev
|
Size Change: 0 B Total Size: 10.6 MB ℹ️ View Unchanged
|
adamsilverstein
force-pushed
the
feature/client-side-media-dev
branch
from
63e8707 to
8383b9c
Compare
adamsilverstein
force-pushed
the
74356-ensure-metadata
branch
from
06436fb to
3b4a21c
Compare
github-actions
bot
removed
[Package] Core data
adamsilverstein
force-pushed
the
74356-ensure-metadata
branch
from
3b4a21c to
37da852
Compare
|
Flaky tests detected in acd74f8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/21646747272
|
adamsilverstein
changed the title
adamsilverstein
added
[Type] Feature
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 7.0 Editor Tasks
adamsilverstein
removed request for
ajitbohra,
ellatrix,
nerrad,
ntwb and
spacedmonkey
adamsilverstein
moved this from 🔎 Needs Review
to 🏗️ In Progress
in WordPress 7.0 Editor Tasks
github-actions
bot
removed
[Package] Editor
Expands test coverage for issue #74356 to ensure client-side media uploads preserve the same EXIF data as traditional server-side processing. New tests verify: - exif_orientation field is returned in REST API response - EXIF orientation is preserved when generate_sub_sizes=false - Full EXIF metadata (camera, aperture, ISO, focal length) is extracted - IPTC metadata (credit, caption, copyright, title) is extracted - Sideloading sub-sizes preserves original image_meta - Sideloaded sub-sizes have complete metadata (file, dimensions, mime, filesize) - exif_orientation is properly defined in REST API schema - Metadata consistency between server-side and client-side upload flows Also fixes a bug where EXIF orientation 0 (undefined/no EXIF data) was being returned instead of 1 (no rotation needed). The controller now treats orientation <= 0 as "no rotation needed". Co-Authored-By: Claude Opus 4.5 <[email protected]>
…ntroller-test.php Co-authored-by: Copilot <[email protected]>
adamsilverstein
force-pushed
the
74356-ensure-metadata
branch
from
306a8ad to
b3dbca7
Compare
adamsilverstein
moved this from 🏗️ In Progress
to 🔎 Needs Review
in WordPress 7.0 Editor Tasks
The controller uses 'mime-type' (with hyphen) but the test was asserting against 'mime_type' (with underscore). Co-Authored-By: Claude Opus 4.5 <[email protected]>
The REST API converts 'mime-type' (hyphen) to 'mime_type' (underscore) for JSON API consistency in prepare_item_for_response(). The test assertions should use 'mime_type' to match the actual response format. Co-Authored-By: Claude Opus 4.5 <[email protected]>
adamsilverstein
changed the base branch from
feature/client-side-media-dev
to
trunk
adamsilverstein
changed the base branch from
trunk
to
feature/client-side-media-dev
adamsilverstein
added
the
No Core Sync Required
adamsilverstein
changed the title
adamsilverstein
added a commit
that referenced
this pull request
Feb 4, 2026
adamsilverstein
changed the title
Links Gutenberg PR #74909 to WordPress Core backport PR #10868. Co-Authored-By: Claude Opus 4.5 <[email protected]>
adamsilverstein
changed the title
andrewserong
approved these changes
Feb 5, 2026
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
Nice, this looks very thorough to me! Also TIL that EXIF orientation values begin at 1 👍
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #74356
Summary
Expands test coverage for #74356 to ensure client-side media uploads preserve the same EXIF data as traditional server-side processing.
New Tests
test_exif_orientation_field_returned_in_responseexif_orientationfield is in REST API responsetest_exif_orientation_returned_for_rotated_imagetest-image-upside-down.jpg(EXIF orientation 3)test_server_side_exif_rotation_disabled_for_client_side_processinggenerate_sub_sizes=falsetest_full_exif_metadata_extracted_for_client_side_uploadtest_exif_and_iptc_metadata_extractedtest_sideload_preserves_image_metatest_sideloaded_subsize_has_complete_metadatatest_exif_orientation_in_schemaexif_orientationis properly defined in REST API schematest_metadata_consistency_between_upload_flowsBug Fix
Fixes a bug where EXIF orientation
0(undefined/no EXIF data) was being returned instead of1(no rotation needed). The controller now treatsorientation <= 0as "no rotation needed".Test plan
npm run test:unit:php -- --filter="Gutenberg_REST_Attachments_Controller_Test"🤖 Generated with Claude Code