Skip to content

Use Object.defineProperty instead of delete for test globals #74992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Copilot wants to merge 2 commits into from
Closed

Use Object.defineProperty instead of delete for test globals #74992

Copilot wants to merge 2 commits into from
+30 −12

Conversation

Copy link
Contributor

Copilot AI commented Jan 27, 2026 •
edited
Loading

Addresses feedback on #74827 to avoid potential errors when WebAssembly or SharedArrayBuffer are non-configurable globals in the JS engine.

Changes

  • Replace delete global.WebAssembly with Object.defineProperty(global, 'WebAssembly', { value: undefined, ... })
  • Replace delete global.SharedArrayBuffer with Object.defineProperty(global, 'SharedArrayBuffer', { value: undefined, ... })
  • Align with existing crossOriginIsolated test pattern for consistency

Before:

it( 'returns not supported when WebAssembly is unavailable', () => {
    // @ts-ignore - Intentionally removing WebAssembly for testing.
    delete global.WebAssembly;
    
    const result = detectClientSideMediaSupport();
    // ...
} );

After:

it( 'returns not supported when WebAssembly is unavailable', () => {
    // Override WebAssembly to simulate it being unavailable.
    Object.defineProperty( global, 'WebAssembly', {
        value: undefined,
        writable: true,
        configurable: true,
    } );
    
    const result = detectClientSideMediaSupport();
    // ...
} );

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI mentioned this pull request Jan 27, 2026
Open
4 tasks
Copy link
Contributor Author

Copilot AI commented Jan 27, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • translate.wordpress.org
    • Triggering command: /usr/local/bin/node node i18n-cache/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Address feedback on WebAssembly support detection and fallbacks Use Object.defineProperty instead of delete for test globals Jan 27, 2026
Copilot AI requested a review from adamsilverstein January 27, 2026 21:13
@github-actions
Copy link

github-actions bot commented Jan 27, 2026

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Required label: Any label starting with [Type].
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@adamsilverstein adamsilverstein marked this pull request as ready for review January 27, 2026 21:25
@github-actions
Copy link

github-actions bot commented Jan 27, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @Copilot.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: Copilot.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

Assignees

@adamsilverstein adamsilverstein

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adamsilverstein