Improve sync performance metrics #75029
Merged
+399
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriszarate
added
[Type] Performance
|
Size Change: +238 B (+0.01%) Total Size: 3 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
alecgeatches
approved these changes
Jan 29, 2026
Contributor
alecgeatches
left a comment
alecgeatches
left a comment
There was a problem hiding this comment.
Couple of minor comments above, plus some failing e2e tests related to post dirty state. Looks good to me otherwise.
In my testing I didn't notice any issues due to the timing change, but we should keep an eye out for those. There's a lot of tricky timings related to undo and selection updates that depend on firing before or after CRDT changes, but I didn't see any in testing.
chriszarate
force-pushed
the
improve/sync-performance
branch
from
db4eece to
e6e3665
Compare
Contributor
Author
|
Performance tests are here and are consistent with https://github.com/WordPress/gutenberg/actions/runs/21876243921/job/63145814804 Merging and will separately evaluate the impact of removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Improve the performance of syncing for the all sync providers (not just the default provider).
Why?
Performance metrics are negatively impacted if sync is enabled—even if there is only a single editor / collaborator.
It's critical to ensure that this feature does not degrade the performance of Gutenberg.
How?
SyncManagerare wrapped to log performance timing when a debug flag is passed. 734045eawaitthe promise when loading an entity for syncing. Testing has shown this has no impact. 953b8eatypeoption for the sync REST API endpoint. This was probably not a measurable performance drag, but was generating a warning that makes testing noisy. 3641ab6Testing Instructions
Sync is already enabled via 48e7ce9 so that this PR can demonstrate progress on performance metrics. It can be reverted before merge.
falsetotruehere.Testing Instructions for Keyboard
n/a