-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fix dev build for fresh checkouts (or with build/scripts/block-library missing) #75108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
1 similar comment
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 3 MB ℹ️ View Unchanged
|
Mamaduka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm that this fixes the issue ✅
The build process also generates a manifest after the wp-build call, so the solution here seems logical to me.
bin/dev.mjs
Outdated
| // Build blocks manifests after initial build completes | ||
| console.log( '\n📦 Building blocks manifests...' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I will remove that. It also looked odd to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed in a15c698
Merging once CI passes.
…y missing) (#75108) * fix dev build for fresh checkouts * Remove confusing console log
…y missing) (#75108) * fix dev build for fresh checkouts * Remove confusing console log

What?
Fix a dev build issue with fresh checkouts.
Closes #75107
How?
Claude suggested running the failing step later, which worked in my testing. I'm uncertain if this the right spot or best approach, but I did verify this fixes the issue.
Testing Instructions
rm -R buildnpm run devBuild should complete and wait for changes.