-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Add load_on_client_navigation to wp_register_script_module #10236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
samueljseay
wants to merge
15
commits into
WordPress:trunk
from
samueljseay:dev/load-modules-client-navigation-script-modules-option
+203
−9
Closed
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4dfc1ec
Add support for script module arg load_on_client_navigation
samueljseay 306aa51
Add supporting tests for the new script module option.
samueljseay f8848b9
Only add the attribute to enqueued script modules, not preloads.
samueljseay 2168fd6
Remove test code dealing with preloads
samueljseay 3900cf4
Fix type doc formatting.
samueljseay e4a32b8
Improve test readability
samueljseay 18533b3
Add the load attribute when detecting interactivity blocks, add suppo…
samueljseay 032c826
Test registration of interactivity blocks includes the load on naviga…
samueljseay 38988ac
Don't json encode very simple data.
samueljseay 2c24ef2
Merge remote-tracking branch 'origin/trunk' into dev/load-modules-cli…
samueljseay 1128587
Update src/wp-includes/class-wp-script-modules.php
samueljseay 0aa3c0f
Update src/wp-includes/class-wp-script-modules.php
samueljseay eed4b7d
Update src/wp-includes/script-modules.php
samueljseay 82a5002
Update src/wp-includes/script-modules.php
samueljseay aec1945
Update tests/phpunit/tests/script-modules/wpScriptModules.php
samueljseay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There could be interactive blocks that don't support client-side navigation. I guess it's not important in this case because navigation doesn't happen when the target page contains any of these blocks, although we could prevent downloading some bytes here if we only set
truefor those that support client navigation.cc: @luisherranz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean
supports.interactivity = { interactive: true, clientNavigation: false }?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, that's the case I have in mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should take that into account 🙂