-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Help/About: Update performance content and images #10524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
@westonruter I'm looking at the About page performance string and I wonder if it could be updated for flow. What do you think of the following?
|
|
@ryelle that works for me! I would add one additional word: put "other" before "core optimizations". They are all core optimizations in the end. |
|
Or "additional core optimizations" |
|
Sounds good, "additional" just fits to match line-length with Accessibility.
Just waiting a bit longer to see if there is any more feedback about the way to mark this up for translations. |
peterwilsoncc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Strings in WP are treated as trusted and can use the inline tags, it's very common.
As one example of many,
| $publish_box .= '<li>' . __( '<strong>Format</strong> — Post Formats designate how your theme will display a specific post. For example, you could have a <em>standard</em> blog post with a title and paragraphs, or a short <em>aside</em> that omits the title and contains a short text blurb. Your theme could enable all or some of 10 possible formats. <a href="https://developer.wordpress.org/advanced-administration/wordpress/post-formats/#supported-formats">Learn more about each post format</a>.' ) . '</li>'; |
c0ae32d to
589f06e
Compare
|
Committed in r61257 |

This adds the correct string for performance changes, updates the header images to not have rounded corners, and updates the release badge to use the stylized 6.9 icon.
Trac ticket: https://core.trac.wordpress.org/ticket/63941
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.