Skip to content

Block Bindings: Try supporting custom, dynamic block attributes with role: content property #7597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
artemiomorales wants to merge 3 commits into
base: trunk
Choose a base branch
from
+14 −7
Draft

Block Bindings: Try supporting custom, dynamic block attributes with role: content property #7597

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb928bb
Try test HTML_Serialization_Builder class with Block Bindings
artemiomorales Oct 21, 2024
c1ff857
Lock processing to custom, dynamic blocks' role: content attributes
artemiomorales Oct 24, 2024
acdb660
Remove Serialization Builder class
artemiomorales Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions src/wp-includes/class-wp-block.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,13 +251,11 @@ private function process_block_bindings() {
'core/button' => array( 'url', 'text', 'linkTarget', 'rel' ),
);

// If the block doesn't have the bindings property, isn't one of the supported
// If the block doesn't have the bindings property, is a core block and isn't one of the supported
// block types, or the bindings property is not an array, return the block content.
if (
! isset( $supported_block_attributes[ $this->name ] ) ||
empty( $parsed_block['attrs']['metadata']['bindings'] ) ||
! is_array( $parsed_block['attrs']['metadata']['bindings'] )
) {
$bindings_present = isset( $parsed_block['attrs']['metadata']['bindings'] ) && is_array( $parsed_block['attrs']['metadata']['bindings'] );
$is_core_block = strpos( $this->name, 'core/' ) === 0;
if ( ! $bindings_present || ( $is_core_block && ! isset( $supported_block_attributes[ $this->name ] ) ) ) {
return $computed_attributes;
}

Expand Down Expand Up @@ -297,9 +295,18 @@ private function process_block_bindings() {

foreach ( $bindings as $attribute_name => $block_binding ) {
// If the attribute is not in the supported list, process next attribute.
if ( ! in_array( $attribute_name, $supported_block_attributes[ $this->name ], true ) ) {
if ( $is_core_block && ! in_array( $attribute_name, $supported_block_attributes[ $this->name ], true ) ) {
continue;
}

// For non-core blocks, if the attribute definition is not set, or the role is not set to 'content', skip the attribute.
$attribute_definition = isset( $this->block_type->attributes[ $attribute_name ] ) ? $this->block_type->attributes[ $attribute_name ] : null;
$role_not_set = isset( $attribute_definition ) && ! isset( $attribute_definition['role'] );
$role_not_content = isset( $attribute_definition['role'] ) && 'content' !== $attribute_definition['role'];
if ( ! $is_core_block && ( ! $attribute_definition || $role_not_set || $role_not_content ) ) {
continue;
}

// If no source is provided, or that source is not registered, process next attribute.
if ( ! isset( $block_binding['source'] ) || ! is_string( $block_binding['source'] ) ) {
continue;
Expand Down