60111 fix/dark mode scripts redundant imports #9083
Closed
+9
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of quirks found in the Trac ticket about assets enqueuing in the Twenty Twenty-One theme. This PR fixes those issues by:
editor-dark-mode-support.jsscript only ifis_admin()is true since that script is not needed on the frontend.the_script()function because it was enqueuing thedark-mode-toggler.jsagain via anincludestatement when it is already being enqueued ineditor_custom_color_variables()Trac ticket: https://core.trac.wordpress.org/ticket/60111
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.