Tests: Add tests for playlist shortcode script loading for first invalid playlist #9228
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-authored-by: Himanshu Pathak <[email protected]>
| static $instance = 0; | ||
| ++$instance; | ||
|
|
||
| static $is_loaded = false; |
There was a problem hiding this comment.
I only took a click glance but can we reuse the static $instance, seems to be the equivalent of $instance > 1
I know the stakes are low for a shortcode, but anything to avoid this antipattern leaking into more places.
There was a problem hiding this comment.
Hey @justlevine,
Thanks for the review.
I have tried reusing the static $instance. Using $instance >= 1 can work, but it will trigger the action for every valid playlist after the first shortcode. Using a static $is_loaded variable ensures the action is only triggered once, for the first valid playlist.
Let me know if you have further thoughts!
…once for invalid playlist
|
Merged in f40b60d. |
4 participants
Trac ticket: #63583
Patch Used: #9003
Description
Added a unit test for
wp_playlist_shortcodeto ensure that playlist scripts are loaded when a valid playlist follows an invalid one.Testing Instructions
Run the following command to verify the tests:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.