Skip to content

build: update dependency webpack-dev-middleware to v8#32895

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:webpack-dev-server-middleware
Mar 30, 2026
Merged

build: update dependency webpack-dev-middleware to v8#32895
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:webpack-dev-server-middleware

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

See associated pull request for more information.

Closes #32816 as a pr takeover

See associated pull request for more information.

Closes angular#32816 as a pr takeover
@alan-agius4 alan-agius4 added the target: minor This PR is targeted for the next minor release label Mar 30, 2026
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Mar 30, 2026
@alan-agius4 alan-agius4 requested a review from clydin March 30, 2026 14:30
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 30, 2026
@alan-agius4 alan-agius4 marked this pull request as ready for review March 30, 2026 14:30
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades webpack-dev-middleware to version 8.0.2 and removes the _karma_webpack_ path prefix from Karma-related configurations, HTML templates, and middleware. The fallbackMiddleware was refactored for better efficiency using a Set for file lookups. Feedback was provided to refine a regular expression in the E2E tests to specifically target the webpack: protocol, ensuring the assertion is not overly broad and avoids potential false positives.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 30, 2026
@alan-agius4 alan-agius4 merged commit a5ab23e into angular:main Mar 30, 2026
39 of 40 checks passed
@alan-agius4
Copy link
Copy Markdown
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4 alan-agius4 deleted the webpack-dev-server-middleware branch March 30, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants