fix(initSpeech): scope click listener to one-off, namespaced handler to avoid external UI conflicts#617
Open
amartincua wants to merge 2 commits intoableplayer:mainfrom
Open
fix(initSpeech): scope click listener to one-off, namespaced handler to avoid external UI conflicts#617amartincua wants to merge 2 commits intoableplayer:mainfrom
amartincua wants to merge 2 commits intoableplayer:mainfrom
Conversation
…external UI events The previous implementation used a global, persistent click listener, which in some environments (notably page builders like Elementor) interfered with other UI components such as popups or dropdowns. Using .one() ensures the listener is automatically removed after the first click, reducing overhead and risk of side effects. Adding an event namespace (.ableInitSpeech) makes the listener easier to manage and avoids conflicts with other click handlers.
amartincua
changed the title
Fixe typo.
joedolson
reviewed
May 27, 2025
Member
joedolson
left a comment
joedolson
left a comment
There was a problem hiding this comment.
Fixed a typo, but otherwise I think this makes sense. Because this is an edit to the built file and a PR against main it's not mergeable, but I'll add props.
Member
I should have read more closely; that wasn't a typo. Regardless, not mergeable because it's to a built file. But shouldn't using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation used a global, persistent click listener, which in some environments (notably page builders like Elementor) interfered with other UI components such as popups or dropdowns.
Using .one() ensures the listener is automatically removed after the first click, reducing overhead and risk of side effects.
Adding an event namespace (.ableInitSpeech) makes the listener easier to manage and avoids conflicts with other click handlers.