Add type hint for decorated function#533
Merged
sseliverstov merged 2 commits intoallure-framework:masterfrom Dec 7, 2020
jackblk:master
Merged
Add type hint for decorated function#533sseliverstov merged 2 commits intoallure-framework:masterfrom jackblk:master
sseliverstov merged 2 commits intoallure-framework:masterfrom
jackblk:master
Conversation
Currently some language servers cannot parse the type of wrapped functions. _TFunc is bounded to the function.
add one more space to pass static check
sseliverstov
approved these changes
Dec 7, 2020
This was referenced Jun 15, 2021
beckerGil
pushed a commit
to beckerGil/allure-python
that referenced
this pull request
Apr 10, 2023
IvanBuruyane
pushed a commit
to IvanBuruyane/allure-python
that referenced
this pull request
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently some language servers cannot parse the type of wrapped functions. _TFunc is bounded to the function.
Context
Decorated function will lose type hint in some Python language servers (e.g Pylance which VSCode will use officially in the future). Language server is working as intended, and if our wrapper does not change arg types, we should add type hint.
See: microsoft/pyright#774 (comment)
Example code:
VSCode with Pylance:

Argument hint:

After this PR:

Argument hint:

Checklist
No new unit test since no function change. Unit test result is the same to before this PR.