Add support the display of duplicate tag names (fix #832)#852
Add support the display of duplicate tag names (fix #832)#852sharovd wants to merge 1 commit intoallure-framework:masterfrom
Conversation
|
Hi, @sharovd Thank you for investing your time in allure-pytest. The thing is that allure-pytest is unique among other Allure integrations in that it tries to convert to tags something that doesn't really fit into the idea of tags: pytest markers with arguments. I believe implementing this was a mistake, as it creates more problems than it solves. We shouldn't also convert built-in markers, as we have better options to indicate their effect. I've described it in more detail in the issue. And if we don't convert the abovementioned markers, the problem with missing tags will resolve itself (multiple markers with no arguments means the tag values will be the same, and there is no point in having multiple tags with absolutely the same values). We have an existing issue that addresses just that: #817, and we should implement it. If you're still willing to work on markers-to-tags conversion, you may take the implementation from allure-pytest-bdd and adjust the tests accordingly. |
delatrie
force-pushed
the
fix-832-multiple-markers
branch
from
b90428c to
044db77
Compare
sharovd
force-pushed
the
fix-832-multiple-markers
branch
from
044db77 to
e400a8a
Compare
2 participants
Context
case_id) will be fully collected according to the described problemskipif) will still be collected according to the existing testspytest_markers()method and corresponding testtest_show_reserved_pytest_markers_full_decorator()Checklist
P.S.: This is my first open source contribution. I'm happy to improve it if there's anything that needs to be changed or improved. Thanks for reviewing!