Set the correct detail message for passed steps (fix #835)#853
Merged
delatrie merged 2 commits intoallure-framework:masterfrom Apr 24, 2025
Merged
Conversation
delatrie
requested changes
Apr 21, 2025
Contributor
delatrie
left a comment
delatrie
left a comment
There was a problem hiding this comment.
Hi, @sharovd ! Thank you very much for contributing to allure-python.
I've checked the changes, and the code looks good to me. The only missing thing is a test that reproduces the issue. Could you pls add one?
If you need some guidance on how to test allure-robotframework, please let me know, and I will gladly help you.
Contributor
Author
|
Hi, @delatrie! Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
self._current_tbandself._current_msgfields in_report_messages()method in case if step is passed, otherwise the wrong detail message saved for failed step will be used in the report.Checklist