Skip to content

refactor(core): replace with rxjs isObservable#33220

Closed
vthinkxie wants to merge 1 commit intoangular:masterfrom
vthinkxie:application_init_support_observerable
Closed

refactor(core): replace with rxjs isObservable#33220
vthinkxie wants to merge 1 commit intoangular:masterfrom
vthinkxie:application_init_support_observerable

Conversation

@vthinkxie
Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@vthinkxie vthinkxie requested review from a team October 17, 2019 09:31
@vthinkxie vthinkxie force-pushed the application_init_support_observerable branch 3 times, most recently from 37773f5 to f2b0b37 Compare October 17, 2019 12:09
@trotyl
Copy link
Copy Markdown
Contributor

trotyl commented Oct 17, 2019

Duplicate of #27668

@vthinkxie vthinkxie force-pushed the application_init_support_observerable branch from f2b0b37 to 4749ad4 Compare October 17, 2019 13:07
@vthinkxie vthinkxie requested a review from a team October 17, 2019 13:07
@vthinkxie vthinkxie force-pushed the application_init_support_observerable branch from 4749ad4 to bd6d2f4 Compare October 17, 2019 13:32
@matsko matsko added area: core Issues related to the framework runtime type: bug/fix labels Oct 17, 2019
@ngbot ngbot bot modified the milestone: needsTriage Oct 17, 2019
@vthinkxie vthinkxie force-pushed the application_init_support_observerable branch 7 times, most recently from d0d66fb to ac0df72 Compare October 21, 2019 11:17
@vthinkxie vthinkxie requested a review from a team October 21, 2019 11:17
@vthinkxie
Copy link
Copy Markdown
Contributor Author

Duplicate of #27668

more codes need to change after bazel as the default build tool

@vthinkxie vthinkxie force-pushed the application_init_support_observerable branch from ac0df72 to a6ea5f6 Compare October 22, 2019 02:24
@atscott
Copy link
Copy Markdown
Contributor

atscott commented Aug 13, 2020

Closing as duplicate of #27668. Aside from the change in integration/side-effects/snapshots/common/esm5.js (which will fail in CI anyhow and need to be updated there as well), these are identical.

@atscott atscott closed this Aug 13, 2020
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: core Issues related to the framework runtime cla: yes type: bug/fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants