feat(static-reflector): Added StaticReflector#7813
Closed
chuckjaz wants to merge 1 commit intoangular:masterfrom
Closed
feat(static-reflector): Added StaticReflector#7813chuckjaz wants to merge 1 commit intoangular:masterfrom
chuckjaz wants to merge 1 commit intoangular:masterfrom
Conversation
22 tasks
chuckjaz
force-pushed
the
static-reflector
branch
3 times, most recently
from
6a027d5 to
75f61d4
Compare
Contributor
There was a problem hiding this comment.
Could you give this a better return type?
Contributor
Author
There was a problem hiding this comment.
This is a map in dart. How do I specify, more specifically, what the map must contain?
Contributor
There was a problem hiding this comment.
We have the special builtin {[key:KeyType]:ValueType} that will work in TS and be converted into a Map via ts2dart
tbosch
added
pr_state: LGTM
action: cleanup
chuckjaz
force-pushed
the
static-reflector
branch
from
75f61d4 to
4c7cfe8
Compare
Added a static reflector that uses metadta produced during build or, additionally, directly from typescript, to produce the metadata used by Angular code generation compiler.
chuckjaz
force-pushed
the
static-reflector
branch
from
4c7cfe8 to
2a5674b
Compare
chuckjaz
added
action: merge
|
Merging PR #7813 on behalf of @jeffbcross to branch presubmit-jeffbcross-pr-7813. |
Contributor
|
Closed with 0dbf959 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a static implementation of the
ReflectorReaderAPI that allows constructing metadata from the persistent format produced by theMetadataCollectorintools. This implementation can be passed toDirectiveResolver,PipeResolverandViewResolverwhich then can be passed toRuntimeMetadataResolverto produce theCompileDirectiveMetadataandCompilePipeMetadatanecessary to parse a template withTemplateParserwithout loading or running the corresponding modules.n/a
TemplateParsercan be used to compile a template without requiring the modules referenced being loaded. This is particularly helpful when the compiler needs to run in a more trusted environment than the template being compiled or when the template is for an incomplete type such as in an editor when using the parser for diagnostics and completions.No.
Added a static reflector that uses metadata produced during build
or, additionally, directly from typescript, to produce the metadata
used by Angular code generation compiler.