Skip to content

feat: drop mirror signal in favor of linked signal #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jefiozie merged 1 commit into from
Feb 2, 2025
Merged

feat: drop mirror signal in favor of linked signal #493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions projects/angular-split/src/lib/split-area/split-area.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,10 @@ import {
inject,
input,
isDevMode,
linkedSignal,
} from '@angular/core'
import { SPLIT_AREA_CONTRACT, SplitComponent } from '../split/split.component'
import { createClassesString, mirrorSignal } from '../utils'
import { createClassesString } from '../utils'
import { SplitAreaSize, areaSizeTransform, boundaryAreaSizeTransform } from '../models'

@Component({
Expand Down Expand Up @@ -39,19 +40,15 @@ export class SplitAreaComponent {
/**
* @internal
*/
readonly _internalSize = mirrorSignal(
// As size is an input and we can change the size without the outside
// listening to the change we need an intermediate writeable signal
computed((): SplitAreaSize => {
if (!this.visible()) {
return 0
}
readonly _internalSize = linkedSignal((): SplitAreaSize => {
if (!this.visible()) {
return 0
}

const visibleIndex = this.split._visibleAreas().findIndex((area) => area === this)
const visibleIndex = this.split._visibleAreas().findIndex((area) => area === this)

return this.split._alignedVisibleAreasSizes()[visibleIndex]
}),
)
return this.split._alignedVisibleAreasSizes()[visibleIndex]
})
/**
* @internal
*/
Expand Down
21 changes: 1 addition & 20 deletions projects/angular-split/src/lib/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { NgZone, Signal, computed, inject, numberAttribute, signal, untracked } from '@angular/core'
import { NgZone, inject, numberAttribute } from '@angular/core'
import { Observable, filter, fromEvent, merge } from 'rxjs'

export interface ClientPoint {
Expand Down Expand Up @@ -106,25 +106,6 @@ export function createClassesString(classesRecord: Record<string, boolean>) {
.join(' ')
}

export interface MirrorSignal<T> {
(): T
set(value: T): void
reset(): void
}

/**
* Creates a semi signal which allows writes but is based on an existing signal
* Whenever the original signal changes the mirror signal gets aligned
* overriding the current value inside.
*/
export function mirrorSignal<T>(outer: Signal<T>): MirrorSignal<T> {
const inner = computed(() => signal(outer()))
const mirror: MirrorSignal<T> = () => inner()()
mirror.set = (value: T) => untracked(inner).set(value)
mirror.reset = () => untracked(() => inner().set(outer()))
return mirror
}

export function leaveNgZone<T>() {
return (source: Observable<T>) =>
new Observable<T>((observer) => inject(NgZone).runOutsideAngular(() => source.subscribe(observer)))
Expand Down