refactor: use 'import type' for types and interfaces#529
Merged
Jefiozie merged 2 commits intoangular-split:mainfrom Feb 18, 2026
Merged
refactor: use 'import type' for types and interfaces#529Jefiozie merged 2 commits intoangular-split:mainfrom
Jefiozie merged 2 commits intoangular-split:mainfrom
Conversation
kukreja-vikramaditya
force-pushed
the
refactor-import-type
branch
2 times, most recently
from
7937dee to
55a27c5
Compare
kukreja-vikramaditya
force-pushed
the
refactor-import-type
branch
from
55a27c5 to
eb8042b
Compare
SanderElias
approved these changes
Feb 16, 2026
There was a problem hiding this comment.
Pull request overview
This PR refactors TypeScript imports across the angular-split library to use the import type syntax for types and interfaces, addressing lint issues related to the isolatedModules compiler option as introduced in TypeScript 3.8.
Changes:
- Added
import typesyntax for type-only imports throughout the library - Updated public API exports to use inline
typekeyword for type exports - Ensured runtime values (functions, classes) remain as regular imports/exports
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| public_api.ts | Updated exports to use inline type keyword for type exports (AngularSplitDefaultOptions, SplitGutterTemplateContext) and separate export type statement for model types |
| validations.ts | Changed imports of SplitAreaSize, SplitUnit, and SplitAreaComponent to use import type |
| split.component.ts | Changed imports of SplitAreaSize, SplitGutterInteractionEvent, SplitAreaComponent, and ClientPoint to use import type |
| split-area.component.ts | Used inline type keyword for SplitAreaSize while keeping runtime functions as regular imports |
| split-gutter.directive.ts | Changed import of SplitAreaComponent to use import type |
| angular-split-config.token.ts | Changed imports of SplitDir, SplitDirection, and SplitUnit to use import type |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Jefiozie
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps avoid lint issues related to isolatedModules as mentioned in https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html