Improved ansible code, removed dependency#32
Improved ansible code, removed dependency#32hryamzik wants to merge 2 commits intoansiblebit:masterfrom
Conversation
hryamzik
commented
Mar 21, 2017
- replaced shell with modules
- replaced fail-based checks with changing based ones
- removed launchpad-ppa-webupd8 dependency – looks too complicated for such a simple role
- cleaned up README
- changed defaults to set java as default – I do hate changing default behaviour but hey, you expect role to install java in a useful way when applying role with no arguments!
…defaults to set java as default
|
@hryamzik this is failing on travis: I'll test this on the vagrant boxes but it would be good if you could have a look. usage of |
|
Tests do not set Ansible 2.x is out there for a while and brings us a lot of good stuff. Why support 1.9? |
|
it's ok to drop ansible 1.9 support but there are several files that need to be updated. I've fixed the other minor issues. I never run a playbook with |
|
continued on #33 ... |
|
Thanks! |