Remove 'debian | ubuntu | check if oracle license is already accepted'#42
Merged
steenzout merged 1 commit intoansiblebit:masterfrom May 19, 2017
cwardgar:remove-license-check
Merged
Remove 'debian | ubuntu | check if oracle license is already accepted'#42steenzout merged 1 commit intoansiblebit:masterfrom cwardgar:remove-license-check
steenzout merged 1 commit intoansiblebit:masterfrom
cwardgar:remove-license-check
Conversation
The task is unnecessary; it only saves us from running 'debian | set license as accepted'. However, that task is already idempotent; if the license is already accepted, it does nothing. Furthermore, the deleted task was problematic because it used 'debconf-get-selections', which might not be installed (it wasn't for me in Ubuntu 16.04). Rather than installing 'debconf-utils', why not just nuke the useless task?
Member
|
sure. thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The task is unnecessary; it only saves us from running 'debian | set license as accepted'.
However, that task is already idempotent; if the license is already accepted, it does nothing.
Furthermore, the deleted task was problematic because it used 'debconf-get-selections', which
might not be installed (it wasn't for me in Ubuntu 16.04). Rather than installing 'debconf-utils',
why not just nuke the useless task?