Skip to content

Revert "Support paging for scan api"#427

Merged
zhoney merged 1 commit intomasterfrom
revert-361-scan-with-page
Apr 2, 2019
Merged

Revert "Support paging for scan api"#427
zhoney merged 1 commit intomasterfrom
revert-361-scan-with-page

Conversation

@javeme
Copy link
Copy Markdown
Contributor

@javeme javeme commented Apr 2, 2019

Reverts hugegraph/hugegraph#361

@javeme
Copy link
Copy Markdown
Contributor Author

javeme commented Apr 2, 2019

The API is missing some parameter: #414

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2019 •
edited
Loading

Codecov Report

Merging #427 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #427      +/-   ##
============================================
- Coverage     70.16%   70.11%   -0.06%     
+ Complexity     3274     3265       -9     
============================================
  Files           208      208              
  Lines         16050    16042       -8     
  Branches       2301     2297       -4     
============================================
- Hits          11262    11248      -14     
- Misses         3536     3544       +8     
+ Partials       1252     1250       -2
Impacted Files Coverage Δ Complexity Δ
.../hugegraph/backend/store/rocksdb/RocksDBTable.java 79.54% <100%> (+0.19%) 31 <0> (-2) ⬇️
...aidu/hugegraph/backend/store/hbase/HbaseTable.java 83.16% <100%> (+0.31%) 34 <0> (-2) ⬇️
...ugegraph/backend/cache/CachedGraphTransaction.java 98.36% <100%> (ø) 20 <4> (-1) ⬇️
...c/main/java/com/baidu/hugegraph/util/JsonUtil.java 56.6% <0%> (-5.67%) 4% <0%> (-1%)
...aidu/hugegraph/backend/page/PageEntryIterator.java 76.92% <0%> (-5.13%) 13% <0%> (-1%)
...e/src/main/java/com/baidu/hugegraph/HugeGraph.java 70.87% <0%> (-0.65%) 60% <0%> (ø)
...va/com/baidu/hugegraph/backend/cache/RamCache.java 67.06% <0%> (-0.41%) 41% <0%> (-1%)
...du/hugegraph/backend/tx/GraphIndexTransaction.java 79.39% <0%> (-0.16%) 145% <0%> (-1%)
...a/com/baidu/hugegraph/backend/query/Condition.java 62.96% <0%> (+0.52%) 20% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60d8d8f...007bb95. Read the comment docs.

@zhoney zhoney merged commit 582793d into master Apr 2, 2019
@zhoney zhoney deleted the revert-361-scan-with-page branch April 2, 2019 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Linary Linary Linary approved these changes

@zhoney zhoney zhoney approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@javeme @Linary @zhoney