Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ vrunoa
✅ KazuCocoa
✅ ki4070ma
❌ Daniel-Graham-SL1298

@dpgraham
I've checked in my local, webdriver_test.py needs fix from its check.
(At least, python -m isort -rc . works in my local)

Please run below command.

$python -m isort -rc test/unit/webdriver/webdriver_test.py

@ki4070ma I tried that already and it still fails the test

@dpgraham
Add mock = "~=3.0" to Pipfile.

https://github.com/appium/python-client/blob/master/Pipfile

https://pypi.org/project/mock/

Error log from Travis

Traceback:

test/unit/webdriver/webdriver_test.py:22: in <module>

    from mock import patch

E   ImportError: No module named mock

9e46aa1
mm, my change does not appear here. <= It delayed appearing on GitHub

isort seems to depend on environment.
By hand and by pre-commit hook on my end got a different result.
The former addressed 9e46aa1 , but the later had no issue without the change.

@KazuCocoa
Sorry for confusing you, this change(f2a6abd) is from github.com directly, so pre-commit doesn't run.

No.
I meant the result of isort by hand, python -m isort -rc ., and by pre-commit had a different result on my local.
We should consider if we continue to use it or fix the dependency.

https://pypi.org/project/Appium-Python-Client/0.47/
cc @vrunoa