Skip to content

feat: make the UA format with same as other clients#793

Merged
KazuCocoa merged 7 commits intomasterfrom
ua
Jun 9, 2023
Merged

feat: make the UA format with same as other clients#793
KazuCocoa merged 7 commits intomasterfrom
ua

Conversation

@KazuCocoa
Copy link
Copy Markdown
Member

@KazuCocoa KazuCocoa commented Oct 29, 2022

Current UA in this library is appium/python 0.49 (selenium/3.141.0 (python linux))).
Like Java and Ruby clients, this lib also can follow a similar format with /version. e.g. https://github.com/appium/java-client/blob/8ebb5c320a1b98fbc14ac2f2c9cec1447db76c34/src/main/java/io/appium/java_client/AppiumUserAgentFilter.java#L46-L47 So, it will be appium/0.49 (selenium/3.141.0 (python linux)))

@KazuCocoa KazuCocoa requested a review from ki4070ma October 29, 2022 20:08
@KazuCocoa KazuCocoa changed the title chore: set version with / feat: make the UA format with same as other clients May 29, 2023
@mykola-mokhnach
Copy link
Copy Markdown
Contributor

@KazuCocoa could you please rebase and rerun tests?

@KazuCocoa
Copy link
Copy Markdown
Member Author

oh, test failures came from the desired_capabilities issue

@KazuCocoa KazuCocoa merged commit f304f65 into master Jun 9, 2023
@KazuCocoa KazuCocoa deleted the ua branch June 9, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants