This repository was archived by the owner on Jan 14, 2018. It is now read-only.
Change pan gesture behavior to the old one#338
Closed
Lascorbe wants to merge 3 commits intoECSlidingViewController:masterfrom
Wallapop:master
Closed
Change pan gesture behavior to the old one#338Lascorbe wants to merge 3 commits intoECSlidingViewController:masterfrom Wallapop:master
Lascorbe wants to merge 3 commits intoECSlidingViewController:masterfrom
Wallapop:master
Conversation
So the animation happens with the pan gesture movement
|
+1 - that change created a worse user experience. Maybe there was an underlying reason for it, but hopefully there's another way it could be fixed. |
|
+1 There is also another PR that dupes this fix with 2 supporters. |
|
+1 on here too. We should probably get rid of one of these duplicate pull requests. |
|
+1 |
|
Any chance this could be merged soon ? |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So the animation happens with the pan gesture movement of the user.
@lemonkey explains it very well on the commit that changed it