Conversation
…hed to a single team when the repos start the same way
|
Thanks, looks great! I'm unable to work on this right now, but we'll get it merged over the weekend. A couple of quick comments:
Neither of which are show stoppers, and I'll fix it up before merging... if you've not done so by then ;) |
|
Actually, looks like this can't be merged in its current state. On top of the issues from my previous comment
|
|
I rewrote the functionality in JNRowe/python-github2@feat/gooseprojects_teams, it fixes the problems I mentioned in the earlier comments. It also changes the functionality slightly, as GitHub specify qualified project names when adding teams we use that in the Probably needs some more testing... |
|
Seems fine to me. If you cannot tell, I wasn't sure what the datatype= actually accomplished. It's a bit clearer here and I will try to make sure to include the proper return datatype in the future. Glad to have helped, even if just to get the concept into code. |
Yep, that really should be documented somewhere. If you are playing with the code and find other things you just cannot get your head around feel free to open an issue. Documentation tends to get written as someone points out a gap ;)
A pull request is always a great help, even if it has a couple of problems. Thanks for that. I'll play with these changes some more later, just to make sure I haven't done something silly. And merge them later today if no problems turn up. A new release is coming over the next few days, and these additions will be in it. |
|
Merged in 8b860ac. Thanks, again. |
I figure this functionality might be useful. Let me know if you would like anything cleaned up before submitting.