Adding support for capturing the output of a node instance for custom…#184
Adding support for capturing the output of a node instance for custom…#184pauldotknopf wants to merge 1 commit intoaspnet:devfrom pauldotknopf:console-logging
Conversation
Adding support for capturing the output of a node instance for custom logging implementations.
|
Great point, best way to handle it IMHO to replace every Console.WriteLine to ILogger.Write, and inject logger from DI. Does it make sense for you? |
|
The |
|
Are you referring to using the Microsoft libraries for logging? |
|
Yep, it is. And yep it need to be refactored :) |
|
Thanks @pauldotknopf! This is now merged (commit 27ffa7). Instead of the custom The various Hope this meets your needs, but please let me know if you have any concerns. I haven't yet actually published updated NuGet packages containing this, as I'm waiting first to see if anyone thinks there's any problem with this. |
… logging implementations.
Not all implementations rely on stdout for logging and error messages.