Add container as viable setup #20
Merged
semiherdogan merged 7 commits intobb-cli:mainfrom Nov 6, 2024
laluowen:main
Merged
Conversation
Member
|
Hi, |
Contributor
Author
|
That makes sense - it should be fairly easy to add Docker Hub to the mix instead, just that GHCR is easily available and Actions runners get credentials vended to them as necessary without any extra effort needed. Merging this PR would effectively build and package at |
Member
|
I have tried locally and it works without any errors. We will merge this PR. |
Member
|
@Mediowen thank you for your work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I don't like adding extra runtimes for CLI tools, but this is basically the only CLI-friendly Bitbucket API client I could find (thanks for this! 😁). I took it upon myself to setup a Docker container workflow that'd build and push to GitHub Container Registry at release time, so there's a lower-impact option for those who don't feel like contending with PHP directly.
Please let me know if this is desired at all - it works really well for me and the tool is small and light enough that I don't feel any extra overhead running it as a container. For what it's worth, you can see the end product here (though this will naturally publish as
ghcr.io/bb-cli/bb-cli): https://github.com/mediowen/bb-cli/pkgs/container/bb-cli. To test, you can just usealias bb='docker run -it --mount type=bind,source="$HOME/.bitbucket-rest-cli-config.json",target=/root/.bitbucket-rest-cli-config.json --mount type=bind,source="$(pwd)",target=/workdir --rm ghcr.io/mediowen/bb-cli:1.2.0As per your own recommendation, I'd suggest squashing this PR :) many commits are just bits of trial/error.
Thanks!