解除不必要的同步,之前的同步会导致严重性能问题。#384
Merged
binarywang merged 1 commit intobinarywang:developfrom Nov 24, 2017
Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
之前对于executeInternal全部使用了synchronized,导致在大量用户登录的时候,由于http本身的操作时延,造成大量阻塞,导致系统无法使用。
实际上大量的synchronized 都可以去除,特别对于token的操作,建议由独立进程刷新,也可以通过类似guavaCache的方式,确保token随时可用。