CIF parsing: entity type should be case insensitive#1109
Merged
josemduarte merged 2 commits intobiojava:masterfrom Mar 18, 2025
Merged
CIF parsing: entity type should be case insensitive#1109josemduarte merged 2 commits intobiojava:masterfrom
josemduarte merged 2 commits intobiojava:masterfrom
Conversation
sbittrich
approved these changes
Mar 18, 2025
Member
sbittrich
left a comment
sbittrich
left a comment
There was a problem hiding this comment.
LGTM, thanks.
I would go with equalsIgnoreCase directly. Is the change in visiblity for the constructor intended?
biojava-structure/src/main/java/org/biojava/nbio/structure/EntityType.java
Outdated
Show resolved
Hide resolved
…ityType.java Co-authored-by: Sebastian Bittrich <[email protected]>
Contributor
Author
Apparently it's optional in enum constructor (an IntelliJ tip) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some PDB-IHM files use upper case, unlike PDB files that use lower case.