Fix __signature__ support if object has a __file__#992
Merged
sebastinas merged 1 commit intobpython:mainfrom Jul 20, 2023
Merged
Fix __signature__ support if object has a __file__#992sebastinas merged 1 commit intobpython:mainfrom
sebastinas merged 1 commit intobpython:mainfrom
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #992 +/- ##
==========================================
- Coverage 76.36% 76.35% -0.01%
==========================================
Files 61 61
Lines 8284 8291 +7
==========================================
+ Hits 6326 6331 +5
- Misses 1958 1960 +2
|
Contributor
|
Could you please add a test case covering such a class? |
Contributor
Author
|
I updated the previous test to test this edge case :p |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #932. I missed an edge-case :(
If a class uses exotic
__signature__typings, but also has a__file__(thatinspect.getsourcelinesfinds), then it is ignored whenever_fix_default_valuesdoesn't work. In this case it should just 'trust' the__signature__.