Skip to content

Fixed minor typo in readme#1

Closed
jeremyharris wants to merge 1 commit intocakephp:masterfrom
jeremyharris:patch-1
Closed

Fixed minor typo in readme#1
jeremyharris wants to merge 1 commit intocakephp:masterfrom
jeremyharris:patch-1

Conversation

@jeremyharris
Copy link
Member

Fixed a super minor typo in the readme.

@ADmad
Copy link
Member

ADmad commented Oct 1, 2014

This is a read-only repo, please reopen the PR against main cakephp repo.

@ADmad ADmad closed this Oct 1, 2014
@lorenzo
Copy link
Member

lorenzo commented Oct 1, 2014

@jeremyharris Thanks, but can you do the change in the main CakePHP repo? This is meant as a read-only lib

@jeremyharris
Copy link
Member Author

Sure no problem!

markstory pushed a commit that referenced this pull request Apr 5, 2015
lorenzo pushed a commit that referenced this pull request Oct 25, 2015
markstory pushed a commit that referenced this pull request Mar 19, 2022
Exception: unlink(): Argument #1 ($filename) must be of type string, bool given
In [/home/wotanabx/webseiten/wow-das/vendor/cakephp/cakephp/src/Cache/Engine/FileEngine.php, line 227]

2022-03-11 02:32:30 error: [TypeError] unlink(): Argument #1 ($filename) must be of type string, bool given in /home/wotanabx/webseiten/wow-das/vendor/cakephp/cakephp/src/Cache/Engine/FileEngine.php on line 227
markstory pushed a commit that referenced this pull request Feb 25, 2026
…200)

* WIP: Add proper generic type annotations to fix PHPStan missingType.generics

This is a work-in-progress to properly specify generic types instead of
ignoring the missingType.generics errors in PHPStan.

Changes include:
- Add @template annotations to Helper, View subclasses, Cache classes
- Add proper generic type parameters to method signatures
- Fix Collection, ORM, Event system generic types

Progress: ~210 of 405 errors fixed (52%)

Remaining work needed for complete fix.

* Additional fixes from parallel agents

* Fix remaining missingType.generics errors

Complete the fix for generic type annotations by:
- Add generic types to Association.php methods (attachTo, find, etc.)
- Add @phpstan-ignore for self-referential generics in EventDispatcherTrait
- Fixes all remaining missingType.generics errors

Remaining 69 errors are different types (return.type, argument.type,
generics.interfaceConflict) not related to the original missingType.generics issue.

* Fix PHPStan errors to make CI green

- Add @phpstan-ignore comments for Collection return type mismatches
- Add path-specific ignores for generics.interfaceConflict in TreeIterator/TreePrinter
- Add path-specific ignores for argument.type covariance issues in Cache/ORM
- Use consistent SelectQuery generic types in Association.php

* Move argument.type ignores to inline comments

- Cache.php: inline ignore for NullEngine fallback
- TableRegistry.php: inline ignore for TableLocator
- bootstrap.php: inline ignore for TableLocator

generics.interfaceConflict must remain in config (PHPStan limitation
for class-level interface conflicts)

* Improve inline ignore comments wording

* Fix phpcs violations

- Remove unused import EntityInterface from EagerLoader
- Remove @inheritdoc when combined with @param/@return (coding standard violation)
- Add proper type hints and @param annotations

* Merge pull request #1 from rochamarcelo/suggestions-generic-usage-on-view

Suggestions  for generic usage on view

* Cleanup.

* use static instead of self used generic template on command (#2)

* use static instead of self used generic template

* use static instead of self used generic template

* Fix PHPStan errors in ORM association cascade delete methods

Add @phpstan-ignore for argument.type errors where cascade callback
code iterates over query results. The SelectQuery template includes
array type for non-hydrated results, but cascade callbacks always
use hydration, so entities are guaranteed.

---------

Co-authored-by: Marcelo Rocha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants