v2.0.0 by Jonahss · Pull Request #116 · appium/java-client

Jonahss · 2014-09-26T00:59:58Z

This is just a merge of the "interfacesRefactor` branch, plus reimplementation of ScrollTo.

only doing this as a PR so that @bootstraponline and @TikhomirovSergey can review the scrollTo stuff

…ement.

…ract.

appium#105. Act II. AppiumDriver became abstract.

appium#110 Fix

…ement.

…ract.

bootstraponline · 2014-09-26T01:11:28Z

scroll code looks good. 👍

TikhomirovSergey · 2014-09-26T14:09:08Z

Hi! Guys!
Scrolls are great! But there are some issues. They are logical. I'll show my improvements soon. Please wait for a bit time.

Change log: - MobileElement has become abstract. It implements FindsByAccessibilityId - AndroidElement and IOSElement have been created. - AndroidElement implements FindsByAndroidAutomator. - IOSElement implements FindsByIosAutomation. - Both AppiumDriver and MobileElement implement ScrollsTo. Yeah! MobileElement is scrollable too! - PageFactory facilities are synchronized with changes above.

TikhomirovSergey · 2014-09-26T16:28:58Z

Please look at Jonahss#1

It is from one more temporary fork. Please merge it if it is ok.

TikhomirovSergey · 2014-09-26T18:08:19Z

I have changed scrollTo and scrollToExact. They return MobileElement. I think it is possible that somebody wants to do something with element. So why does it need to perform search twice?

Final improvements before 2.0.

Jonahss · 2014-09-26T18:23:28Z

@TikhomirovSergey What do you think of that? Removing scrollTo() from AndroidElement since we aren't changing the scrolling context (it's always the first .scrollable(true) element). If a user needs to scroll something else, they will have to use the UiSelectors themselves.

In the future, if we can come up with a good unified way of scrolling on iOS and Android, we could try to implement it into Appium itself.

TikhomirovSergey · 2014-09-26T18:29:17Z

Hmm... Ok. Let remove it from AndroidElement. But if it needs to be implemented in the future it is always possible to get back to this idea :)

TikhomirovSergey · 2014-09-26T18:41:24Z

If there is any question I shall return over 2 hours.

Jonahss · 2014-09-26T18:51:57Z

I already removed it, look at my latest commit.
I'll wait two hours :)

On Fri, Sep 26, 2014 at 11:41 AM, Sergey Tikhomirov <
[email protected]> wrote:

If there is any questions I shall return over 2 hours.

—
Reply to this email directly or view it on GitHub
#116 (comment).

TikhomirovSergey · 2014-09-26T21:02:51Z

I already removed it, look at my latest commit.

It is ok! I have seen it.

If there is any question I shall return over 2 hours.
I'll wait two hours :)

Actually I meant some questions, issues which could be found and so on. :) But if there is nothing to discuss lets merge it.

Have a nice day!

Jonahss · 2014-09-26T21:13:12Z

Wahoooooo!
Running tests...

On Fri, Sep 26, 2014 at 2:02 PM, Sergey Tikhomirov <[email protected]

wrote:

I already removed it, look at my latest commit.

It is ok! I have seen it.

If there is any question I shall return over 2 hours.
I'll wait two hours :)

Actually I meant some questions, issues which could be found and so on. :)
But if there is nothing to discuss lets merge it!

—
Reply to this email directly or view it on GitHub
#116 (comment).

Jonahss · 2014-09-26T22:21:34Z

@TikhomirovSergey this test fails, what would you suggest?

@Test
    public void isRemoteElementTest(){
        Assert.assertNotEquals(null, remotetextVieW.getAttribute("text"));
    }

org.openqa.selenium.NoSuchElementException: Cann't locate an element by this strategy: By.AndroidUIAutomator: new UiSelector().resourceId("android:id/text1")
For documentation on this error, please visit: http://seleniumhq.org/exceptions/no_such_element.html
Build info: version: '2.43.1', revision: '5163bceef1bc36d43f3dc0b83c88998168a363a0', time: '2014-09-10 09:43:55'
System info: host: 'Jonahs-MacBook-Air.local', ip: '10.35.4.71', os.name: 'Mac OS X', os.arch: 'x86_64', os.version: '10.9.4', java.version: '1.7.0_67'
Driver info: driver.version: unknown
    at io.appium.java_client.pagefactory.AppiumElementLocator.findElement(AppiumElementLocator.java:132)
    at io.appium.java_client.pagefactory.ElementInterceptor.intercept(ElementInterceptor.java:26)
    at org.openqa.selenium.remote.RemoteWebElement$$EnhancerByCGLIB$$5e30ad6f.getAttribute(<generated>)
    at io.appium.java_client.pagefactory_tests.AndroidPageObjectTest.isRemoteElementTest(AndroidPageObjectTest.java:236)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
    at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
    at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
    at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
    at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
    at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
    at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
    at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
    at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
    at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
    at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
    at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
    at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
    at org.junit.runners.Suite.runChild(Suite.java:127)
    at org.junit.runners.Suite.runChild(Suite.java:26)
    at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
    at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
    at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
    at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
    at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
    at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
    at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
    at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:74)
    at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:211)
    at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:67)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at com.intellij.rt.execution.application.AppMain.main(AppMain.java:134)

TikhomirovSergey · 2014-09-26T22:53:54Z

I am trying to find the root cause. Is it the single failure? Did you try to rerun this test? I ran page object android tests. There were no failure. It is strange...

TikhomirovSergey · 2014-09-26T23:00:33Z

By default Appium Field Decorator has 1 second as default time out. Is it possible that element weren't present after 1 second? Actually I use Genymotion instead of Android SDK emulator (it is too slow).

TikhomirovSergey · 2014-09-26T23:12:37Z

@AndroidFindBy(uiAutomator = "new UiSelector().resourceId(\"android:id/text1\")")
private List<RemoteWebElement> remoteElementViews;


@AndroidFindBy(uiAutomator = "new UiSelector().resourceId(\"android:id/text1\")")
private RemoteWebElement remotetextVieW;

Here is the test which checks the list:

        @Test
    public void areRemoteElementsTest(){
        Assert.assertNotEquals(0, remoteElementViews.size());
    }

It has passed.

TikhomirovSergey · 2014-09-26T23:19:28Z

I think it is casual failure. If there is only this problem then identical test should be succeed with iOS here:

        @Test
    public void isRemoteElementTest(){
        Assert.assertNotEquals(null, remotetextVieW.getText());
    }

TikhomirovSergey · 2014-09-26T23:26:17Z

Let replace string

PageFactory.initElements(new AppiumFieldDecorator(driver), this);

by

PageFactory.initElements(new AppiumFieldDecorator(driver, 5, TimeUnit.SECONDS), this);

in AndroidPageObjectTest

Anyway tests with default time out are here and here

TikhomirovSergey · 2014-09-26T23:30:05Z

did it help you?

TikhomirovSergey · 2014-09-27T16:39:41Z

My answer is here: Jonahss#2

TikhomirovSergey · 2014-09-27T16:52:27Z

What are you think about inclusion of information about Genymotion use cases in tutorial ? Have you tried it?

It works much faster than Android SDK emulator and ADB recognizes it as a connected device.

Jonahss · 2014-09-29T19:02:21Z

Official Appium tests are run on Android SDK Emulators and we only officially support it.
Genymotion is fine, but if there are specific bugs with it, we can't support them. Unless somebody wants to add Genymotion support to appium :)

Jonahss · 2014-09-29T19:02:40Z

But you can add it to the tutorial sure ^.^ if it works.

AndroidPageObjectTest improvement.

v2.0.0

TikhomirovSergey · 2014-09-30T07:15:15Z

Wow! It is released. Thanks, @Jonahss!

Appium works fine with Genymotion. I am not kidding you :) At least all java-client tests for Android are completed successfully, except set/get connection. Sometimes they fail because of an unknown to me reason. There is nothing special to do.

TikhomirovSergey · 2014-09-30T07:38:27Z

I hope people will appreciate the new solution :)

Jonahss · 2014-09-30T17:22:58Z

:D

Feel free to add the genymotion tutorial then :)

On Tue, Sep 30, 2014 at 12:38 AM, Sergey Tikhomirov <
[email protected]> wrote:

I hope people will appreciate the new solution :)

—
Reply to this email directly or view it on GitHub
#116 (comment).

TikhomirovSergey and others added 19 commits September 12, 2014 20:02

New interfaces. The beginning of appium#105 fix

a729d73

appium#105 appium#108 AndroidDriver. AppiumDriver. Implement & improv…

59c1486

…ement.

appium#105 & appium#108 IOSDriver. AppiumDriver. InteractsWithApps.

c158b00

more refactoring. moved tests around, added AppiumDriverTests

5988801

appium#108 appium#105 Refactor is going on. AppiumDriver is made abst…

cadd0b0

…ract.

Merge pull request appium#113 from TikhomirovSergey/interfacesRefactor

8b012e9

appium#105. Act II. AppiumDriver became abstract.

appium#100 Fix

202d271

Merge pull request appium#114 from TikhomirovSergey/interfacesRefactor

edbcbee

appium#110 Fix

moved context tests around, added AppiumDriverTest

8f2d86e

reimplemented ScrollTo() and ScrollToExact()

e6a2790

New interfaces. The beginning of appium#105 fix

0102e91

appium#105 appium#108 AndroidDriver. AppiumDriver. Implement & improv…

07c3327

…ement.

appium#105 & appium#108 IOSDriver. AppiumDriver. InteractsWithApps.

dddb062

more refactoring. moved tests around, added AppiumDriverTests

81be93b

appium#108 appium#105 Refactor is going on. AppiumDriver is made abst…

15ba3c2

…ract.

appium#100 Fix

3efe96e

moved context tests around, added AppiumDriverTest

d9c5ab4

Reimplemented ScrollTo() and ScrollToExact()

cd5bc3e

v2.0.0

c8e81b6

Jonahss added 2 commits September 26, 2014 11:11

Merge pull request #1 from arachnidium/master

6a5dcf4

Final improvements before 2.0.

removed scrollTo() from AndroidElement

88197f7

AndroidPageObjectTest improvement.

1d45e63

TikhomirovSergey mentioned this pull request Sep 27, 2014

AndroidPageObjectTest improvement. Jonahss/java-client#2

Merged

Merge pull request #2 from arachnidium/master

f7687da

AndroidPageObjectTest improvement.

Jonahss added a commit that referenced this pull request Sep 29, 2014

Merge pull request #116 from Jonahss/master

dbb443a

v2.0.0

Jonahss merged commit dbb443a into appium:master Sep 29, 2014

Uh oh!

Conversation

Jonahss commented Sep 26, 2014

Uh oh!

bootstraponline commented Sep 26, 2014

Uh oh!

TikhomirovSergey commented Sep 26, 2014

Uh oh!

TikhomirovSergey commented Sep 26, 2014

Uh oh!

TikhomirovSergey commented Sep 26, 2014

Uh oh!

Jonahss commented Sep 26, 2014

Uh oh!

TikhomirovSergey commented Sep 26, 2014

Uh oh!

TikhomirovSergey commented Sep 26, 2014

Uh oh!

Jonahss commented Sep 26, 2014

Uh oh!

TikhomirovSergey commented Sep 26, 2014

Uh oh!

Jonahss commented Sep 26, 2014

Uh oh!

Jonahss commented Sep 26, 2014

Uh oh!

TikhomirovSergey commented Sep 26, 2014

Uh oh!

TikhomirovSergey commented Sep 26, 2014

Uh oh!

TikhomirovSergey commented Sep 26, 2014

Uh oh!

TikhomirovSergey commented Sep 26, 2014

Uh oh!

TikhomirovSergey commented Sep 26, 2014

Uh oh!

TikhomirovSergey commented Sep 26, 2014

Uh oh!

TikhomirovSergey commented Sep 27, 2014

Uh oh!

TikhomirovSergey commented Sep 27, 2014

Uh oh!

Jonahss commented Sep 29, 2014

Uh oh!

Jonahss commented Sep 29, 2014

Uh oh!

TikhomirovSergey commented Sep 30, 2014

Uh oh!

TikhomirovSergey commented Sep 30, 2014

Uh oh!

Jonahss commented Sep 30, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants