Skip to content

Comments

[WIP] Markush#49

Open
TimurGimadiev wants to merge 5 commits intochython:masterfrom
TimurGimadiev:markushi
Open

[WIP] Markush#49
TimurGimadiev wants to merge 5 commits intochython:masterfrom
TimurGimadiev:markushi

Conversation

@TimurGimadiev
Copy link
Member

Let`t start with Markushi
As a feature u can do str(MarkushiContainer), then put it to Marvin and it will show the structure.
Then you can save mrv and parse it back to MarkushiContainer (not perfect, but work)
Looking back for comments. I know that it has copy paste code, but I think it is much more safe for the first period to avoid breaking of native classes.

@TimurGimadiev
Copy link
Member Author

X atoms not implemented yet

TimurGimadiev and others added 2 commits September 26, 2024 01:54
smiles generator fixed.
removed overengineering.

TODO: finish MRV and MarkushContainer.
@stsouko
Copy link
Member

stsouko commented Sep 30, 2024

Partially refactored.
TODO: MRV and markush container.

API discussion and use cases are required!

@stsouko stsouko changed the title Markushi [WIP] Markush Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants