Merged
Conversation
ghost
assigned
Member
|
I think I'll be a little more comfortable merging this if there was also a test making sure that this did what it's supposed to do. Glyn, please feel free to merge and add the test later if you think this is a reasonable implementation. |
Member
|
Yes, please add a test case that should fail before the code fix and that succeeds after. You can put this test inside uri_test.cpp. |
added 3 commits
December 7, 2012 15:35
Author
|
I added the test case and the fix with addition of typedef's in network::http::request_header/response_header because header concept requirements. Async http server can't be build without this fix. |
deanberris
added a commit
that referenced
this pull request
Jan 20, 2014
deanberris
added a commit
that referenced
this pull request
Jan 20, 2014
Backport fix for #163 into 0.11.0
leecoder
pushed a commit
to leecoder/cpp-netlib
that referenced
this pull request
Apr 14, 2015
leecoder
pushed a commit
to leecoder/cpp-netlib
that referenced
this pull request
Apr 14, 2015
…-163-patch Backport fix for cpp-netlib#163 into 0.11.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.