avoid false positives on transform issue27#217
Closed
geoffviola wants to merge 1 commit intocpplint:developfrom
Closed
avoid false positives on transform issue27#217geoffviola wants to merge 1 commit intocpplint:developfrom
geoffviola wants to merge 1 commit intocpplint:developfrom
Conversation
tkruse
force-pushed
the
develop
branch
5 times, most recently
from
b683f2b to
2cb090b
Compare
Contributor
|
Since cpplint has been used in the past to detect missing includes when using |
|
Could the behavior be controlled through an option? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #27
I noticed some false positives when using
transformin other namespaces. There may be some new false negatives whenusing namespace stdis used andstd::is omitted, but it seems worth it.