fix(whitespace/indent_namespace): Three false positives#376
Merged
aaronliu0130 merged 4 commits intodevelopfrom Nov 28, 2025
Merged
fix(whitespace/indent_namespace): Three false positives#376aaronliu0130 merged 4 commits intodevelopfrom
aaronliu0130 merged 4 commits intodevelopfrom
Conversation
This was referenced Oct 27, 2025
cclauss
requested changes
Nov 28, 2025
…es for constructors Fix false positive for when a function specifier (e.g. `inline`, `protected`) is provided Fix false positive for when constructor ends on the same line a MemInitList does, but on a different line from said list's start Fix ownership assignment of open parentheses Use search instead of match for some cases Fix typo & misc refactoring
Fixes `: a({0}), b{"c", d}` etc. F/Ps
Consumes and updates state of MemInitList so we get to the curly braces before _ConsumeEnd() does
Splits ending token searches/checks into `_ConsumeEnd()`
Requires starting index to initialize `_WrapInfo`s
Renames _WrappedInfo to _WrapInfo since Wrapped is not a noun
…ned consumption Fix the direction in which we find braces Fix bug where consumption doesn't happen due to return None without returning the consumed line Refactored consumption functions to have the loop themselves Change tests to account for that
aaronliu0130
force-pushed
the
falsepositive
branch
from
f0168fd to
032ab5f
Compare
aaronliu0130
temporarily deployed
to
testpypi
GitHub Actions
Inactive
cclauss
approved these changes
Nov 28, 2025
aaronliu0130
temporarily deployed
to
testpypi
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #372
fix(whitespace/indent_namespace): Specifier & multiline false positives for constructors
inline,protected) is providedfix(whitespace/indent_namespace): Curly braces in MemInitList
: a({0}), b{"c", d}etc. F/Ps_ConsumeEnd()_WrapInfos