Clean up DataJoint project, fix #338 and #340, and reorganize package content#341
Merged
dimitri-yatsenko merged 13 commits intodatajoint:masterfrom Jul 28, 2017
Merged
Clean up DataJoint project, fix #338 and #340, and reorganize package content#341dimitri-yatsenko merged 13 commits intodatajoint:masterfrom
dimitri-yatsenko merged 13 commits intodatajoint:masterfrom
Conversation
eywalker
changed the title
dimitri-yatsenko
approved these changes
Jul 28, 2017
dimitri-yatsenko
approved these changes
Jul 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #338 and #340
matplotliborpygraphvizimport,dj.ERDis replaced with a stub function that issues warnings when invoked, fixing Make graphviz optional #338MANIFEST.inhas been added to includerequirements.txtinto the source distribution, thereby fixing Fix source file distribution #340Dockerfiles except for the mainDockerfilehas been removed in accordance to the proposal in Migrate all DataJoint related Dockerfiles into a single repo #339pygraphvizandmatplotlibare no longer part of strict requirements as spelled out inrequirements.txt.test_requirements.txtlisting packages that should be installed to fully test DataJoint (i.e.pygraphvizandmatplotlib)..travis.ymlhas been updated to reflect this change.