Fix #382 - deprecate ignore_errors and fix errorneous skip_duplicates behavior#383
Merged
dimitri-yatsenko merged 4 commits intodatajoint:masterfrom Oct 24, 2017
Merged
Conversation
eywalker
changed the title
ignore_errorsignore_errors and fix errorneous skip_duplicates behavior
|
looks good to me; |
dimitri-yatsenko
approved these changes
Oct 24, 2017
| warnings.simplefilter('always') | ||
| self.connection.query(*args, suppress_warnings=False, **kwargs) | ||
| for w in ws: | ||
| # 1062 is MySQL's error code for duplicated entry |
Member
There was a problem hiding this comment.
This comment is redundant (should be with the server_error_codes)
Contributor
Author
There was a problem hiding this comment.
Ah yes, that's redundant - forgot to remove it after I switched to using server_error_codes
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #382
ignore_errorsininsertis now deprecated - errors are no longer suppressed with this option and warnings are returned notifying users of this deprecationskip_duplicates=Trueno longer suppresses other errorsskip_duplicates=True