Add Network create attribute#2344
Conversation
|
/assign @eddumelendez |
|
Hi, thanks for the PR. I don't see the created attribute in Network create operation https://docs.docker.com/engine/api/v1.45/#tag/Network/operation/NetworkCreate |
|
Thanks for your quick review. Then I guess it is only valido for inspect. in that case, should I create a new object for inspectNetworkResponse?, to just add this attribute to it? https://docs.docker.com/engine/api/v1.45/#tag/Network/operation/NetworkInspect |
|
Oh ok, it belongs to the inspect network response. There is similar things for containers so let's keep it as it. It should be reviewed in the future. |
|
Checking createNetwork return a CreateNetworkResponse, it does not contains createTime. Network Object is used to return Network information, it contains the creation time |
|
Some unrelated test are failing, not sure why. |
|
Thanks for your contribution, @juanmolle ! |
This PR Parse Create attribute from Network Object
Related: #2343