Merged
Conversation
Member
jamesgeorge007
left a comment
jamesgeorge007
left a comment
There was a problem hiding this comment.
Let's rename it to generate. Can you write tests?
Koooooo-7
reviewed
Jan 16, 2021
Member
|
FYI, I run the |
anikethsaha
approved these changes
Jan 16, 2021
jamesgeorge007
requested changes
Jan 18, 2021
Member
jamesgeorge007
left a comment
jamesgeorge007
left a comment
There was a problem hiding this comment.
Looking good, left a couple of suggestions.
lib/commands/generate.js
Outdated
|
|
||
| if (!exists(sidebarPath)) { | ||
| genSidebar(cwdPath, sidebarPath) | ||
| console.log(chalk.green(`Generate sidebar file '${sidebar}' success.`)) |
Member
There was a problem hiding this comment.
Suggested change
| console.log(chalk.green(`Generate sidebar file '${sidebar}' success.`)) | |
| console.log(chalk.green(`Successfully generated the sidebar file '${sidebar}'.`)) |
Member
There was a problem hiding this comment.
It is better to have a logger utility. There are a couple of places that require an update; feel free to address it in a future PR.
- console.error(chalk.red(msg))
+ logger.error(msg)// logger.js
const error = (msg) => console.error(chalk.red(msg));
Member
Author
There was a problem hiding this comment.
After the merge, I will submit a PR to amend this
Co-authored-by: James George <[email protected]>
jamesgeorge007
approved these changes
Jan 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have tested it under mac, can anyone test it in other environments?
feat: docsifyjs/docsify#1290
fix: docsifyjs/docsify#1323
fix: docsifyjs/docsify#1444