Add Redis durablejobs Implementation #9823
Open
+1,954
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jaironalves <[email protected]>
…cture Co-authored-by: jaironalves <[email protected]>
Co-authored-by: jaironalves <[email protected]>
…evert NuGet.Config Co-authored-by: jaironalves <[email protected]>
…Extensions Co-authored-by: jaironalves <[email protected]>
…led) Co-authored-by: jaironalves <[email protected]>
Co-authored-by: jaironalves <[email protected]>
Co-authored-by: jaironalves <[email protected]>
…onContext Co-authored-by: jaironalves <[email protected]>
…Azure implementation Co-authored-by: jaironalves <[email protected]>
… implementation Co-authored-by: jaironalves <[email protected]>
…cript Co-authored-by: jaironalves <[email protected]>
Co-authored-by: jaironalves <[email protected]>
- Create RedisJobShardManager.Log.cs with partial methods using LoggerMessage attributes - Update RedisJobShardManager.cs to use the new partial log methods - Follow the same pattern used in AzureStorageJobShardManager and RedisJobShard Co-authored-by: jaironalves <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
…urableJobs package Co-authored-by: jaironalves <[email protected]>
- Fix TaskCompletionSource type inconsistency (use non-generic version) - Use consistent ConfigureAwait pattern with Azure implementation - Fix batch collection logic to use TryPeek instead of TryRead/TryWrite - Initialize MetadataVersion from metadata dictionary in constructor - Add local function for batch collection consistency with Azure Co-authored-by: jaironalves <[email protected]>
Critical fix: Use expectedVersion instead of MetadataVersion when calculating newVersion in ExecuteUpdateMetadataAsync to prevent race conditions and ensure proper CAS semantics. Add comprehensive review document detailing all findings. Co-authored-by: jaironalves <[email protected]>
Co-authored-by: jaironalves <[email protected]>
The review findings have been documented in the PR description instead. Co-authored-by: jaironalves <[email protected]>
…bs Redis Co-authored-by: jaironalves <[email protected]>
Co-authored-by: jaironalves <[email protected]>
Co-authored-by: jaironalves <[email protected]>
- Add braces on new lines for foreach loops in RedisJobShard.cs - Add braces on new line for catch block in RedisJobShard.cs - Addresses unresolved PR review comments about code formatting Co-authored-by: jaironalves <[email protected]>
src/Redis/Orleans.DurableJobs.Redis/Hosting/RedisJobShardOptionsValidator.cs
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
test/Extensions/Tester.Redis/DurableJobs/RedisJobShardManagerTestFixture.cs
Outdated
Show resolved
Hide resolved
src/Redis/Orleans.DurableJobs.Redis/Hosting/RedisDurableJobsExtensions.cs
Outdated
Show resolved
Hide resolved
| /// <summary> | ||
| /// Represents an operation to be performed on a durable job. | ||
| /// </summary> | ||
| internal readonly struct JobOperation |
There was a problem hiding this comment.
The JobOperation struct should be marked with readonly keyword for consistency with C# 13 best practices and to prevent accidental mutations. The Azure implementation at src/Azure/Orleans.DurableJobs.AzureStorage/JobOperation.cs uses struct without readonly, but given that all properties are init-only and the coding guidelines emphasize using latest C# features, this should be readonly struct.
test/Extensions/Tester.Redis/DurableJobs/RedisJobShardManagerTests.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow