Fix some lints. Fixed implementations of some map functions

bryanjos · bryanjos · commit cc32253e64ff · 2017-07-02T20:34:42.000-05:00
diff --git a/lib/elixir_script/passes/translate/forms/pattern.ex b/lib/elixir_script/passes/translate/forms/pattern.ex
@@ -4,10 +4,12 @@ defmodule ElixirScript.Translate.Forms.Pattern do
   alias ElixirScript.Translate.Form
   alias ElixirScript.Translate.Forms.Bitstring
 
-  @moduledoc """
+  @moduledoc false
+
+  @doc """
   Handles all pattern matching translations
   """
-
+  @spec compile(list(), map()) :: { list(), list(), map() }
   def compile(patterns, state) do
     patterns
     |> do_compile(state)
@@ -40,6 +42,7 @@ defmodule ElixirScript.Translate.Forms.Pattern do
     { patterns, params, state }
   end
 
+  @spec get_variable_name(atom(), map()) :: atom()
   def get_variable_name(function, state) do
     number = Map.get(state.vars, function)
     String.to_atom("#{function}#{number}")
diff --git a/src/javascript/lib/core/erlang_compat/maps.js b/src/javascript/lib/core/erlang_compat/maps.js
@@ -24,7 +24,7 @@ function find(key, map) {
 function fold(fun, init, map) {
   let acc = init;
 
-  for (const [key, value] of Object.entries(map)) {
+  for (const [key, value] of to_list(map)) {
     acc = fun(key, value, acc);
   }
 
@@ -48,9 +48,13 @@ function to_list(map) {
     return new ErlangTypes.Tuple(BADMAP, map);
   }
 
-  return Object.entries(map).map(entry => {
-    return ErlangTypes.Tuple(...entry);
-  });
+  const list = [];
+
+  for (const key of keys(map)) {
+    list.push(new ErlangTypes.Tuple(key, map[key]));
+  }
+
+  return list;
 }
 
 function from_list(list) {
@@ -67,15 +71,31 @@ function keys(map) {
     return new ErlangTypes.Tuple(BADMAP, map);
   }
 
-  return Object.keys(map);
+  const keys = [];
+
+  for (const key of Object.getOwnPropertySymbols(map)) {
+    keys.push(key);
+  }
+
+  for (const key of Object.getOwnPropertyNames(map)) {
+    keys.push(key);
+  }
+
+  return keys;
 }
 
 function values(map) {
   if (erlang.is_map(map) === false) {
     return new ErlangTypes.Tuple(BADMAP, map);
   }
 
-  return Object.values(map);
+  const theValues = [];
+
+  for (const key of keys(map)) {
+    theValues.push(map[key]);
+  }
+
+  return theValues;
 }
 
 function is_key(key, map) {
@@ -164,5 +184,5 @@ export default {
   merge,
   update,
   get,
-  take,
+  take
 };
diff --git a/test/support/main.ex b/test/support/main.ex
@@ -2,7 +2,6 @@ defmodule Main do
   def start(:normal, [callback]) do
     callback.("started")
 
-    JS.console.log String.valid?("a")
-    JS.console.log String.valid?(1)
+    Enum.each(1..3, fn x -> JS.console.log(x)  end)
   end
 end
