Skip to content

feat: enable release branch option for tag action#9

Merged
MSevey merged 2 commits intomainfrom
sevey/add-release-branch-option
Dec 2, 2023
Merged

feat: enable release branch option for tag action#9
MSevey merged 2 commits intomainfrom
sevey/add-release-branch-option

Conversation

@MSevey
Copy link
Contributor

@MSevey MSevey commented Nov 30, 2023 •
edited by coderabbitai bot
Loading

Overview

related to evstack/ev-node#1362

this change has already been implemented and verified in celestia-app and celestia-node.

This flag is required when making releases not on main or master branches.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Summary by CodeRabbit

  • New Features

    • Introduced an optional release-branch parameter to specify the branch for tag generation in the release workflow.

  • Documentation

    • Minor formatting improvements by removing trailing spaces.

  • Chores

    • Cleaned up redundant formatting issues in documentation.

@coderabbitai
Copy link

coderabbitai bot commented Nov 30, 2023 •
edited
Loading

Walkthrough

The project has introduced a new optional input parameter release-branch for the version release workflow, allowing users to specify a branch for tag generation, defaulting to "main" if unspecified. Additionally, there are minor cosmetic changes in the CONTRIBUTING.md file, where trailing spaces have been removed.

Changes

File Path Change Summary
.github/actions/version-release/action.yml Added optional release-branch input parameter; default set to "main".
CONTRIBUTING.md Removed trailing spaces at the end of lines.

🐇✨
A hop, a skip, in the code we weave,
A branch anew, from which we leave.
No trailing space, no needless mark,
Clean and tidy, our coding lark. 🌿🚀

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@MSevey MSevey requested a review from liamsi as a code owner November 30, 2023 15:29
@MSevey MSevey merged commit a5a6889 into main Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Manav-Aggarwal Manav-Aggarwal Manav-Aggarwal approved these changes

@liamsi liamsi Awaiting requested review from liamsi liamsi is a code owner

+1 more reviewer

@gupadhyaya gupadhyaya gupadhyaya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MSevey @gupadhyaya @Manav-Aggarwal