ci: Reintroduce redis services at 6379#2395
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2395 +/- ##
==========================================
- Coverage 84.43% 82.86% -1.58%
==========================================
Files 122 122
Lines 10732 11493 +761
==========================================
+ Hits 9062 9524 +462
- Misses 1670 1969 +299
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Achal Shah <[email protected]>
achals
force-pushed
the
achal/reintro-redis
branch
3 times, most recently
from
940da68 to
85a4074
Compare
achals
changed the title
felixwang9817
left a comment
felixwang9817
left a comment
There was a problem hiding this comment.
missed a supercharge
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
Signed-off-by: Achal Shah [email protected]
What this PR does / why we need it:
We moved this to a github action in #2350 and #2354 but this change wasn't needed. I'd like to move the tests back to using the standard redis port so that the tests can be run while developing locally without any changes.
Corresponding test changes to use this redis instance and remove the old one will be in a followup PR.
Which issue(s) this PR fixes:
Fixes #